Move __set__ from BaseDescriptor to FieldTypedBaseDescriptor#274
Merged
julianstirling merged 1 commit intomainfrom Mar 2, 2026
Merged
Move __set__ from BaseDescriptor to FieldTypedBaseDescriptor#274julianstirling merged 1 commit intomainfrom
julianstirling merged 1 commit intomainfrom
Conversation
Downstream in OpenFlexure, unit tests often patch live objects to mock their actions. This stopped working when `BaseDescriptor` gained a `__set__` method. Moving `__set__` to `FieldTypedBaseDescriptor` doesn't change any meaningful LabThings functionality but should restore the tests for OpenFlexure.
Barecheck - Code coverage reportTotal: 96.52%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
julianstirling
approved these changes
Mar 2, 2026
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
I have confirmed that the unit tests, integration tests, and server lifecycle tests of the microscope all now pass.
I have also checked the settings all load in the simulation microscope, and the microscope will scans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream in OpenFlexure, unit tests often patch live objects to mock their actions. This stopped working when
BaseDescriptorgained a__set__method.Moving
__set__toFieldTypedBaseDescriptordoesn't change any meaningful LabThings functionality but should restore the tests for OpenFlexure.A quick check suggests that the descriptors that need a
__set__already inherit fromFieldTypedBaseDescriptor, so I don't believe this affects anything important to LabThings, and the tests/mypy analysis confirm this.